v4.1.x: fs/lustre: Remove unneeded includes#8515
Merged
rajachan merged 1 commit intoopen-mpi:v4.1.xfrom Mar 8, 2021
Merged
Conversation
The functionality was migrated to `fs/base/fs_base_get_parent_dir.c` long ago, but the includes stayed. Though in lustre 2.14 `lustre_user.h` moved the inclusion of `linux/fs.h` outside the `__KERNEL__` guard. This triggered now Debian bug #898743 [1], which states that including `sys/mount.h` after `linux/fs.h` breaks compilation. Thus the include removal also avoids this breakage. Closes open-mpi#8508. [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898743 Signed-off-by: Bert Wesarg <bert.wesarg@tu-dresden.de> (cherry picked from commit 5b525b2)
Member
|
LGTM, but I cannot approve |
jsquyres
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functionality was migrated to
fs/base/fs_base_get_parent_dir.clongago, but the includes stayed. Though in lustre 2.14
lustre_user.hmoved the inclusion of
linux/fs.houtside the__KERNEL__guard. Thistriggered now Debian bug #898743 [1], which states that including
sys/mount.hafterlinux/fs.hbreaks compilation. Thus the includeremoval also avoids this breakage.
Closes #8508.
[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898743
Signed-off-by: Bert Wesarg bert.wesarg@tu-dresden.de
(cherry picked from commit 5b525b2)